From 71feedc700ae6884cc253733170b6f03f1227124 Mon Sep 17 00:00:00 2001 From: Jens <1742418+1cu@users.noreply.github.com> Date: Mon, 10 Nov 2025 11:36:44 +0100 Subject: [PATCH] fix: pin nodriver to 0.47 (#675) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ## â„šī¸ Description - Link to the related issue(s): Issue #N/A - Describe the motivation and context for this change. Pin `nodriver` to the last known good 0.47 series so we can avoid the UTF-8 decoding regression in 0.48.x that currently breaks our local mypy/linting runs. ## 📋 Changes Summary - lock runtime dependency `nodriver` to `0.47.*` with an inline comment describing the upstream regression - refresh `pdm.lock` so local/CI installs stay on the pinned version ### âš™ī¸ Type of Change - [x] 🐞 Bug fix (non-breaking change which fixes an issue) - [ ] ✨ New feature (adds new functionality without breaking existing usage) - [ ] đŸ’Ĩ Breaking change (changes that might break existing user setups, scripts, or configurations) ## ✅ Checklist Before requesting a review, confirm the following: - [x] I have reviewed my changes to ensure they meet the project's standards. - [ ] I have tested my changes and ensured that all tests pass (`pdm run test`). - [ ] I have formatted the code (`pdm run format`). - [ ] I have verified that linting passes (`pdm run lint`). - [x] I have updated documentation where necessary. By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice. --- pdm.lock | 8 ++++---- pyproject.toml | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/pdm.lock b/pdm.lock index 9116667..cf5aaef 100644 --- a/pdm.lock +++ b/pdm.lock @@ -5,7 +5,7 @@ groups = ["default", "dev"] strategy = ["inherit_metadata"] lock_version = "4.5.0" -content_hash = "sha256:76ff52a743ae07eb656f450998dd67f0bc441ce4e1c73d550c4b63434eca6541" +content_hash = "sha256:db686d496c2229b3bd3d33e5cddb92024bb15b0641c8cad58af92e97bab507b8" [[metadata.targets]] requires_python = ">=3.10,<3.15" @@ -885,7 +885,7 @@ files = [ [[package]] name = "nodriver" -version = "0.48.1" +version = "0.47.0" requires_python = ">=3.9" summary = "[Docs here](https://ultrafunkamsterdam.github.io/nodriver)" groups = ["default"] @@ -895,8 +895,8 @@ dependencies = [ "websockets>=14", ] files = [ - {file = "nodriver-0.48.1-py3-none-any.whl", hash = "sha256:d94b49fd6ca831fd2546dee1e39d85baa960f52536f46e1dc7e8dcb38e8d82ba"}, - {file = "nodriver-0.48.1.tar.gz", hash = "sha256:4ac8cd88b6af133c26dc157fb78f5ab17462a59b4a0da3304e3af12bbe4b4343"}, + {file = "nodriver-0.47.0-py3-none-any.whl", hash = "sha256:2bdf69eac8fa33de09249fd513d6a70da95fc80809f9f99c4901cb3ae2e06219"}, + {file = "nodriver-0.47.0.tar.gz", hash = "sha256:5fc31182a4db725ea56fc042269a29a13e55a2baf83dfdd730aa851dd5269608"}, ] [[package]] diff --git a/pyproject.toml b/pyproject.toml index 4e2cbec..617cf68 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -38,7 +38,7 @@ dependencies = [ "certifi", "colorama", "jaraco.text", # required by pkg_resources during runtime - "nodriver>=0.47.0", # Updated from 0.39.0 - 0.40-0.44 had issues starting browsers and evaluating self.web_execute("window.BelenConf") fails + "nodriver==0.47.*", # Pin to 0.47 until upstream fixes UTF-8 decoding issues introduced in 0.48 "pydantic>=2.0.0", "ruamel.yaml", "psutil",