Mirrors/kleinanzeigen-bot
1
0
Fork 0
mirror of https://github.com/Second-Hand-Friends/kleinanzeigen-bot.git synced 2026-03-12 18:41:50 +01:00
Code Issues Packages Projects Releases Wiki Activity

refact: use named parameters

Browse Source
This commit is contained in:
sebthom
2025-04-07 21:57:51 +02:00
parent b66c9d37bf
commit aeaf77e5d4
1 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/kleinanzeigen_bot/utils/web_scraping_mixin.py
View File

@@ -353,7 +353,7 @@ class WebScrapingMixin:
:return: The javascript's return value :return: The javascript's return value
""" """
return await self.page.evaluate(javascript, True) return await self.page.evaluate(javascript, await_promise = True, return_by_value = True)
async def web_find(self, selector_type:By, selector_value:str, *, parent:Element = None, timeout:int | float = 5) -> Element: async def web_find(self, selector_type:By, selector_value:str, *, parent:Element = None, timeout:int | float = 5) -> Element:
""" """
@@ -388,13 +388,13 @@ class WebScrapingMixin:
case By.TEXT: case By.TEXT:
ensure(not parent, f"Specifying a parent element currently not supported with selector type: {selector_type}") ensure(not parent, f"Specifying a parent element currently not supported with selector type: {selector_type}")
return await self.web_await( return await self.web_await(
lambda: self.page.find_element_by_text(selector_value, True), lambda: self.page.find_element_by_text(selector_value, best_match = True),
timeout = timeout, timeout = timeout,
timeout_error_message = f"No HTML element found containing text '{selector_value}' within {timeout} seconds.") timeout_error_message = f"No HTML element found containing text '{selector_value}' within {timeout} seconds.")
case By.XPATH: case By.XPATH:
ensure(not parent, f"Specifying a parent element currently not supported with selector type: {selector_type}") ensure(not parent, f"Specifying a parent element currently not supported with selector type: {selector_type}")
return await self.web_await( return await self.web_await(
lambda: self.page.find_element_by_text(selector_value, True), lambda: self.page.find_element_by_text(selector_value, best_match = True),
timeout = timeout, timeout = timeout,
timeout_error_message = f"No HTML element found using XPath '{selector_value}' within {timeout} seconds.") timeout_error_message = f"No HTML element found using XPath '{selector_value}' within {timeout} seconds.")
@@ -463,7 +463,7 @@ class WebScrapingMixin:
if not reload_if_already_open and self.page and url == self.page.url: if not reload_if_already_open and self.page and url == self.page.url:
LOG.debug(" => skipping, [%s] is already open", url) LOG.debug(" => skipping, [%s] is already open", url)
return return
self.page = await self.browser.get(url, False, False) self.page = await self.browser.get(url, new_tab = False, new_window = False)
await self.web_await(lambda: self.web_execute("document.readyState == 'complete'"), timeout = timeout, await self.web_await(lambda: self.web_execute("document.readyState == 'complete'"), timeout = timeout,
timeout_error_message = f"Page did not finish loading within {timeout} seconds.") timeout_error_message = f"Page did not finish loading within {timeout} seconds.")
@@ -506,7 +506,7 @@ class WebScrapingMixin:
content: responseText content: responseText
}} }}
}})) }}))
""", await_promise = True)) """, await_promise = True, return_by_value = True))
if isinstance(valid_response_codes, int): if isinstance(valid_response_codes, int):
valid_response_codes = [valid_response_codes] valid_response_codes = [valid_response_codes]
ensure( ensure(