mirror of
https://github.com/Second-Hand-Friends/kleinanzeigen-bot.git
synced 2026-03-12 10:31:50 +01:00
## ℹ️ Description *Fixes the nodriver 0.47.0 RemoteObject conversion bug that was causing KeyError and TypeError when accessing BelenConf dimensions.* - Link to the related issue(s): Issue #650 - The bot was crashing when downloading ads because nodriver 0.47.0 was returning JavaScript objects as lists of [key, value] pairs instead of proper Python dictionaries, causing BelenConf dimensions to be inaccessible. ## 📋 Changes Summary - **Fixed nodriver RemoteObject conversion bug** in `web_scraping_mixin.py`: - Added detection logic for list-of-pairs format in `web_execute` method - Enhanced `_convert_remote_object_dict` to recursively convert nested structures - Now properly converts JavaScript objects to Python dictionaries - **Bot functionality fully restored** - can now download ads with subcategories and special attributes ### ⚙️ Type of Change - [x] 🐞 Bug fix (non-breaking change which fixes an issue) - [ ] ✨ New feature (adds new functionality without breaking existing usage) - [ ] 💥 Breaking change (changes that might break existing user setups, scripts, or configurations) ## ✅ Checklist - [x] I have reviewed my changes to ensure they meet the project's standards. - [x] I have tested my changes and ensured that all tests pass (`pdm run test`). - [x] I have formatted the code (`pdm run format`). - [x] I have verified that linting passes (`pdm run lint`). - [x] I have updated documentation where necessary. By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.