From 96c02cdc3df0f5a45e33eacacd832dd20ddbe377 Mon Sep 17 00:00:00 2001 From: Meritoo Date: Sun, 10 Sep 2017 10:22:07 +0200 Subject: [PATCH] Tests - verifyMethodVisibilityAndArguments() method - implementation --- .../Common/Tests/Collection/CollectionTest.php | 13 ++++--------- .../Common/Tests/Utilities/DatePeriodTest.php | 9 ++------- 2 files changed, 6 insertions(+), 16 deletions(-) diff --git a/tests/Meritoo/Common/Tests/Collection/CollectionTest.php b/tests/Meritoo/Common/Tests/Collection/CollectionTest.php index f8d85c6..105ade1 100644 --- a/tests/Meritoo/Common/Tests/Collection/CollectionTest.php +++ b/tests/Meritoo/Common/Tests/Collection/CollectionTest.php @@ -10,8 +10,8 @@ namespace Meritoo\Common\Tests\Collection; use ArrayIterator; use Meritoo\Common\Collection\Collection; -use PHPUnit_Framework_TestCase; -use ReflectionClass; +use Meritoo\Common\Type\OopVisibilityType; +use Meritoo\Common\Utilities\TestCase; /** * Tests of the collection of elements @@ -19,7 +19,7 @@ use ReflectionClass; * @author Krzysztof Niziol * @copyright Meritoo.pl */ -class CollectionTest extends PHPUnit_Framework_TestCase +class CollectionTest extends TestCase { /** * An empty collection @@ -306,12 +306,7 @@ class CollectionTest extends PHPUnit_Framework_TestCase public function testExistsVisibilityAndArguments() { - $reflection = new ReflectionClass(Collection::class); - $method = $reflection->getMethod('exists'); - - self::assertTrue($method->isPrivate()); - self::assertEquals(1, $method->getNumberOfParameters()); - self::assertEquals(1, $method->getNumberOfRequiredParameters()); + $this->verifyMethodVisibilityAndArguments(Collection::class, 'exists', OopVisibilityType::IS_PRIVATE, 1, 1); } /** diff --git a/tests/Meritoo/Common/Tests/Utilities/DatePeriodTest.php b/tests/Meritoo/Common/Tests/Utilities/DatePeriodTest.php index ec15cd4..500c1e9 100644 --- a/tests/Meritoo/Common/Tests/Utilities/DatePeriodTest.php +++ b/tests/Meritoo/Common/Tests/Utilities/DatePeriodTest.php @@ -10,9 +10,9 @@ namespace Meritoo\Common\Tests\Utilities; use DateTime; use Generator; +use Meritoo\Common\Type\OopVisibilityType; use Meritoo\Common\Utilities\DatePeriod; use Meritoo\Common\Utilities\TestCase; -use ReflectionClass; /** * Tests of date's period @@ -24,12 +24,7 @@ class DatePeriodTest extends TestCase { public function testConstructorVisibilityAndArguments() { - $reflection = new ReflectionClass(DatePeriod::class); - $constructor = $reflection->getConstructor(); - - self::assertTrue($constructor->isPublic()); - self::assertEquals(2, $constructor->getNumberOfParameters()); - self::assertEquals(0, $constructor->getNumberOfRequiredParameters()); + $this->verifyConstructorVisibilityAndArguments(DatePeriod::class, OopVisibilityType::IS_PUBLIC, 2, 0); } /**