Mirrors/wiosna-dev_common-library
1
0
Fork 1
mirror of https://github.com/wiosna-dev/common-library.git synced 2026-03-12 09:31:51 +01:00
Code Issues Packages Projects Releases Wiki Activity

Fix "Argument 1 of Meritoo\\Common\\Utilities\\Date::getdayofweek expects int, string|false provided" bug pointed by Psalm

Browse Source
This commit is contained in:
Meritoo
2019-06-20 21:11:00 +02:00
parent 4ddc299e5b
commit c5a68b54af
2 changed files with 13 additions and 29 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
tests/Utilities/DateTest.php
View File

@@ -228,7 +228,7 @@ class DateTest extends BaseTestCase
*
* @dataProvider provideIncorrectYearMonthDay
*/
public function testGetDayOfWeekIncorrectValues($year, $month, $day): void
public function testGetDayOfWeekIncorrectValues(int $year, int $month, int $day): void
{
$this->expectException(UnknownDatePartTypeException::class);
self::assertEmpty(Date::getDayOfWeek($year, $month, $day));
@@ -241,7 +241,7 @@ class DateTest extends BaseTestCase
*
* @dataProvider provideYearMonthDay
*/
public function testGetDayOfWeek($year, $month, $day): void
public function testGetDayOfWeek(int $year, int $month, int $day): void
{
self::assertRegExp('/^[0-6]{1}$/', (string)Date::getDayOfWeek($year, $month, $day));
}
@@ -766,20 +766,8 @@ class DateTest extends BaseTestCase
*
* @return Generator
*/
public function provideIncorrectYearMonthDay()
public function provideIncorrectYearMonthDay(): Generator
{
yield[
null,
null,
null,
];
yield[
'',
'',
'',
];
yield[
0,
0,