Mirrors/wiosna-dev_common-library
1
0
Fork 1
mirror of https://github.com/wiosna-dev/common-library.git synced 2026-03-12 09:31:51 +01:00
Code Issues Packages Projects Releases Wiki Activity

PHPUnit > increase code coverage

Browse Source
This commit is contained in:
Meritoo
2019-04-06 08:14:48 +02:00
parent a13a629408
commit e05bc2302d
3 changed files with 128 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/Utilities/Repository.php
View File

@@ -204,13 +204,6 @@ class Repository
*/ */
private static function isSorted($item) private static function isSorted($item)
{ {
// Not sortable?
if (!self::isSortable($item)) {
return false;
}
// It's an object or it's an array and position has been set?
return return
(is_object($item) && null !== $item->getPosition()) (is_object($item) && null !== $item->getPosition())
|| ||

97
tests/Utilities/RepositoryTest.php
View File

@@ -72,6 +72,19 @@ class RepositoryTest extends BaseTestCase
static::assertEquals($before, $after); static::assertEquals($before, $after);
} }
/**
* @param string $description Description of test
* @param array $items Objects who have "getPosition()" and "setPosition()" methods or arrays
* @param array $expected Expected items with positions replenished
*
* @dataProvider provideSortedItems
*/
public function testReplenishPositionsUsingSortedItems(string $description, array $items, array $expected)
{
Repository::replenishPositions($items);
static::assertSame($expected, $items, $description);
}
/** /**
* @param array $items Objects who have "getPosition()" and "setPosition()" methods or arrays * @param array $items Objects who have "getPosition()" and "setPosition()" methods or arrays
* @dataProvider provideArraysWithoutExtremePosition * @dataProvider provideArraysWithoutExtremePosition
@@ -833,4 +846,88 @@ class RepositoryTest extends BaseTestCase
'qb.first_name DESC', 'qb.first_name DESC',
]; ];
} }
public function provideSortedItems()
{
$sortable1 = new Sortable();
$sortable1->setPosition(1);
$sortable2 = new Sortable();
$sortable2->setPosition(2);
$sortable3 = new Sortable();
$sortable3->setPosition(309);
yield[
'An array with 1 item only',
[
[
'test 1',
'position' => 1,
],
],
[
[
'test 1',
'position' => 1,
],
],
];
yield[
'An array with more than 1 item',
[
[
'test 1',
'position' => 1,
],
[
'test 2',
'position' => 2,
],
[
'test 3',
'position' => 309,
],
],
[
[
'test 1',
'position' => 1,
],
[
'test 2',
'position' => 2,
],
[
'test 3',
'position' => 309,
],
],
];
yield[
'1 object only',
[
$sortable1,
],
[
$sortable1,
],
];
yield[
'More than 1 object',
[
$sortable1,
$sortable2,
$sortable3,
],
[
$sortable1,
$sortable2,
$sortable3,
],
];
}
} }

31
tests/ValueObject/TemplateTest.php
View File

@@ -13,6 +13,7 @@ use Meritoo\Common\Exception\ValueObject\Template\InvalidContentException;
use Meritoo\Common\Exception\ValueObject\Template\NotEnoughValuesException; use Meritoo\Common\Exception\ValueObject\Template\NotEnoughValuesException;
use Meritoo\Common\Test\Base\BaseTestCase; use Meritoo\Common\Test\Base\BaseTestCase;
use Meritoo\Common\Type\OopVisibilityType; use Meritoo\Common\Type\OopVisibilityType;
use Meritoo\Common\Utilities\Reflection;
use Meritoo\Common\ValueObject\Template; use Meritoo\Common\ValueObject\Template;
/** /**
@@ -50,6 +51,18 @@ class TemplateTest extends BaseTestCase
new Template($content); new Template($content);
} }
/**
* @param string $description Description of test
* @param string $content Raw string with placeholders (content of the template)
*
* @dataProvider provideValidContent
*/
public function testIsValidUsingValidContent(string $description, string $content): void
{
$template = new Template($content);
static::assertSame($content, Reflection::getPropertyValue($template, 'content', true), $description);
}
/** /**
* @param Template $template Template to fill * @param Template $template Template to fill
* @param array $values Pairs of key-value where: key - name of placeholder, value - value of the * @param array $values Pairs of key-value where: key - name of placeholder, value - value of the
@@ -212,4 +225,22 @@ class TemplateTest extends BaseTestCase
'My name is Jane Brown and I live in NY, USA', 'My name is Jane Brown and I live in NY, USA',
]; ];
} }
public function provideValidContent(): ?Generator
{
yield[
'Template with 1 placeholder',
'%test%',
];
yield[
'Template with 2 placeholders',
'My name is %name% and I am %profession%',
];
yield[
'Template with 2 placeholders that contains space',
'My name is %first name% %last name% and I live in %current location%',
];
}
} }