From f5bafdc969d4290e410cb79493275dce6a697817 Mon Sep 17 00:00:00 2001 From: Meritoo Date: Tue, 26 Sep 2017 12:16:46 +0200 Subject: [PATCH] Minor refactoring --- .../ApiClient/Manager/JsonRpcClientManagerTest.php | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/tests/Meritoo/LimeSurvey/Test/ApiClient/Manager/JsonRpcClientManagerTest.php b/tests/Meritoo/LimeSurvey/Test/ApiClient/Manager/JsonRpcClientManagerTest.php index 14a0be6..42f7f80 100644 --- a/tests/Meritoo/LimeSurvey/Test/ApiClient/Manager/JsonRpcClientManagerTest.php +++ b/tests/Meritoo/LimeSurvey/Test/ApiClient/Manager/JsonRpcClientManagerTest.php @@ -36,7 +36,7 @@ class JsonRpcClientManagerTest extends BaseTestCase static::assertConstructorVisibilityAndArguments(JsonRpcClientManager::class, OopVisibilityType::IS_PUBLIC, 1, 1); } - public function testRunMethod() + public function testRunMethodWithEmptyArrayReturned() { $rpcClient = $this->createMock(RpcClient::class); @@ -51,12 +51,12 @@ class JsonRpcClientManagerTest extends BaseTestCase ->getMock(); $rpcClient - ->expects(static::any()) + ->expects(static::once()) ->method('execute') ->willReturn([]); $manager - ->expects(static::any()) + ->expects(static::once()) ->method('getRpcClient') ->willReturn($rpcClient); @@ -64,18 +64,18 @@ class JsonRpcClientManagerTest extends BaseTestCase static::assertEquals([], $manager->runMethod(MethodType::LIST_SURVEYS)); } - public function testRunMethodWithMockedRpcClient() + public function testRunMethodWithRawDataReturned() { $rpcClient = $this->createMock(RpcClient::class); $manager = $this->createPartialMock(JsonRpcClientManager::class, ['getRpcClient']); $rpcClient - ->expects(static::any()) + ->expects(static::once()) ->method('execute') ->willReturn(SurveyTest::getSurveysRawData()); $manager - ->expects(static::any()) + ->expects(static::once()) ->method('getRpcClient') ->willReturn($rpcClient);